Include dependencies graph in the Metadata
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why a major bump? This only makes previously private fields public. |
mcarton
commented
Jun 12, 2017
| @@ -23,25 +23,43 @@ use std::io; | |||
| pub struct Metadata { | |||
| /// A list of all crates referenced by this crate (and the crate itself) | |||
| pub packages: Vec<Package>, | |||
| resolve: Option<()>, | |||
| /// Dependencies graph | |||
| pub resolve: Option<Resolve>, | |||
There was a problem hiding this comment.
I bumped the version because this type changes.
There was a problem hiding this comment.
Well. The field was private, so it's only a small breaking change since the parsed json is tested more strictly. I think it should be a patch version bump, since no real code should break (it should be valid metadata json to begin with)
There was a problem hiding this comment.
Oh right, don't know what I was thinking there.
|
Thx, will publish on Thursday. Earlier if I have a PC and internet simultaneously |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to use this for https://github.com/Manishearth/rust-clippy/issues/1797.